search

RhodiumGroup / helm-chart

Helm Chart for Rhodiums jupyterhub deployment
https://rhodiumgroup.github.io/helm-chart/
0 stars 0 forks source link

update startup timeout to 10 min #15

Closed bolliger32 closed 3 years ago

bolliger32 commented 3 years ago

instead of 15 min

delgadom commented 3 years ago

thanks! 👍

brews commented 3 years ago

Might want to put a brief writeup (or sentence) on why this change is needed? It's because user jupyterhub pods have a legit long timeout with the coastal images?

bolliger32 commented 3 years ago

@brews No I don't think its something that's coastal specific. We're tightening up the timeout time. It was originally 5 min and that was too short sometimes b/c our images are big. So then we went to 15 min. But @delgadom pointed out that we might be able to get it a little shorter and that would make it quicker to diagnose when there actually is an issue, rather than having to wait 15 min.

Were you thinking document the reason for the change in the code? Or is this comment in the PR what you were looking for

brews commented 3 years ago

Ah! Awesome, thanks much @bolliger32. I'm only now catching up with my slack messages.

Could go either way on where to document it. For something little like this I think it's fine to write our thinking in this PR as it gives us a way to audit the change and understand our thinking if something goes wrong in the near future.

If it is a reaaally critical and sensitive number that some knuckhead might changes and unintentionally break everything -- then I'd say go for an inline comment with big violent letters and threats of an ancient curse.

Does that sound reasonable?

bolliger32 commented 3 years ago

Yeah for sure just added a quick note to guide future knuckleheads