RhodiumGroup / helm-chart

Helm Chart for Rhodiums jupyterhub deployment
https://rhodiumgroup.github.io/helm-chart/
0 stars 0 forks source link

drop num_threads env vars #18

Closed bolliger32 closed 3 years ago

bolliger32 commented 3 years ago

It turns out using profileList.kubespawner_override.environment is problematic, since it overwrites a dictionary that daskhub sets in it's helm chart values. There is no easy way to add to this dictionary, rather than overwrite it. This may be an issue down the line, but I also realized that we don't want to be setting OMP_NUM_THREADS (and the other NUM_THREADS env vars) b/c users might want to use a local dask scheduler, and we don't want this conflicting with numpy. Not setting these vars at all is cleanest and I think in most cases will make dask and numpy play relatively nice together.