RhodiumGroup / rhg_compute_tools

Tools for using compute.rhg.com and compute.impactlab.org
MIT License
1 stars 3 forks source link

Add client_kwargs option and fix datasets_from_delayed #103

Open bolliger32 opened 2 years ago

bolliger32 commented 2 years ago

Not sure whats going on with that failed test at the moment.

delgadom commented 2 years ago

I think this might be the culprit: https://github.com/RhodiumGroup/rhg_compute_tools/blob/client-kwargs/tests/test_rhg_compute_tools.py#L35-L36

def monkeypatch_cluster(func):
    def inner(monkeypatch, mem, cpu, scale):
        ...
        def mock_dask_Client(cluster):
            return cluster  # this gets invoked by `client.gather()` which isn't a method on LocalGateway
        ...

Not sure what the best way around this is if you're avoiding creating a proper dask client, but if not... you could just pass back dd.Client(cluster)

delgadom commented 2 years ago

unless you mean.... not sure why this is popping up now... in which case I agree with you 🤷🏼‍♂️

bolliger32 commented 2 years ago

yeah that's what i was wondering. I feel like there was a reason we couldn't create an actual client here...but can't remember what it was. worth a try at least, i suppose