Enable alternate forms of authentication

RhodiumGroup / rhg_compute_tools

Tools for using compute.rhg.com and compute.impactlab.org

MIT License

1 stars 4 forks source link

Enable alternate forms of authentication #49

Closed delgadom closed 5 years ago

delgadom commented 5 years ago

[x] closes #51
[ ] tests added / passed
[x] docs reflect changes
[ ] passes flake8 rhg_compute_tools tests docs
[x] entry in HISTORY.rst

Makes a couple fixes:

fixes a typo in repdirstruc
allows authentication using the default google auth creds using gcloud init (see google.cloud docs on default auth behavior)

brews commented 5 years ago

@delgadom Hate to say it but I actually just had an idea for how we could maybe make this cleaner and less magical... let me write it up and you can decide which one you like.

brews commented 5 years ago

I have an alternative approach to solving Issue #51 in PR #52. I think the PR #52 approach might be less magical and more flexible for future development.

Need a second opinion on this. @delgadom please see whether you want to want to merge this PR or PR #52 . I'll follow your opinion on this.

(Originally I made the changes here but then reverted and moved it into a different PR so you can compare. Sorry to make a mess of your commit history.)

delgadom commented 5 years ago

superceded by #52