search

RhodiumGroup / rhg_compute_tools

Tools for using compute.rhg.com and compute.impactlab.org
MIT License
1 stars 3 forks source link

modify dict implementation, fix typo #65

Closed dallen5 closed 4 years ago

dallen5 commented 4 years ago

This updates the handling of the env_items parameter in get_cluster(), changing the dictionary unpacking to for k, v in env_items.items() instead of for k, v in env_items.values().

Also, this fixes a typo in the deprecated list-of-dicts implementation (from isintance to isinstance).

Finally, the docstring is updated to match the dict implementation rather than the deprecated list-of-dicts implementation.

delgadom commented 4 years ago

The CI failures look like they're likely an issue with a new version of pytest. I've triggered a build on master to see if we get the same issue.

delgadom commented 4 years ago

Have a fix in #67. We can merge this in once that is merged into master

delgadom commented 4 years ago

Note this PR is waiting on https://github.com/dpa9694/rhg_compute_tools/pull/2

dallen5 commented 4 years ago

@delgadom I merged in those changes, looks like this is passing tests (which seem to have sped up 5-10x??)