Autofmt - Githubissues

RhodiumGroup / rhg_compute_tools

Tools for using compute.rhg.com and compute.impactlab.org

MIT License

1 stars 4 forks source link

Autofmt #71

Closed bolliger32 closed 4 years ago

bolliger32 commented 4 years ago

[ ] tests added / passed (can't figure out what's going on with the sphinx error...builds ok on my notebook image)
[x] docs reflect changes (N/A)
[x] passes flake8 rhg_compute_tools tests docs (some things in tests still raise flake8 warnings, but they are ones that are needed for pytest)
[x] entry in HISTORY.rst (N/A

Started off by just calling black and flake8 on everything. Flake8 caused me to spot a few typos that hadn't caught up to us yet but would soon.

isintance instead of isinstance in kubernetes.py
had not imported warnings in kubernetes.py
weren't removing all the rst files we wanted to when re-generating sphinx apidocs

bolliger32 commented 4 years ago

Hey @brews !

Yeah the summary is just that I started off just trying to clean things up just calling black on everything. We've added black --check . as part of our testing on the coastal team repo and I think it's helped keep things fairly uniform. So i'd be in favor of that if you guys want. Regardless, for the time being, I just thought I would tidy things up a bit. In addition to black, I also ran flake8 just to see what it would come up with (just default settings, except for --max-line-length=88 to match black). I didn't fix everything I dont' think (e.g. I didn't fix all whitespaces) but I fixed the typos it noticed (like when I wrote isintance instead of isinstance).

Previously master was failing so I thought that was the failures that this PR was running into, but I just rebased onto @delgadom 's changes (which are now passing on master) and it's still failing. Not sure what's going on as it's a sphinx-build issue that passes fine on my notebook...

bolliger32 commented 4 years ago

In general reviewing "black everything" PRs is close to impossible so I'd strongly prefer separating this from everything else. Ok if we close this, run black as a separate PR, then try to tackle these remaining items one at a time?

Soundsd good to me! I'll keep this branch and then when we're ready to try again after theres a separate black-only PR we can merge again.

bolliger32 commented 4 years ago

closing - see #75