search

RhodiumGroup / rhg_compute_tools

Tools for using compute.rhg.com and compute.impactlab.org
MIT License
1 stars 3 forks source link

isort everything + 1 change #76

Closed bolliger32 closed 4 years ago

bolliger32 commented 4 years ago

OK @delgadom i knowwww you don't like to mix formatter changes and other changes, but #65 actually fixed one of the two bugs I had noticed. The only other one was that warnings was not imported in kubernetes.py but was potentially being called. So this PR contains that one change, and other than that I just called isort --profile black . and added all those changes (isort v5 now has profiles so you can make sure that isort doesn't do anything that black would then revert). Importantly it doesn't mess up the importing AFTER sys.path in conf.py.

Fixes #75

delgadom commented 4 years ago

Oh just an import. Ok thanks!

bolliger32 commented 4 years ago

Oh just an import. Ok thanks!

Yup! L7 in the new version of kubernetes.py

delgadom commented 4 years ago

I keep hearing about isort. Why is everyone so into sorting imports all of a sudden?

I think if we're going to do any more code formatting, it should be discussed and decided on as an issue, then implemented and enforced with testing, rather than bundled as a one-off change with other fixes. I'm happy going with black and isort across everything but it needs to be a project-level decision and then it needs to be maintained. That sound good? Want to create that issue @bolliger32?

bolliger32 commented 4 years ago

sure

On Fri, Jul 17, 2020 at 8:53 AM Michael Delgado notifications@github.com wrote:

I keep hearing about isort all of a sudden. Why is everyone so into sorting imports all of a sudden?

I think if we're going to do any more code formatting, it should be discussed and decided on as an issue, then implemented and enforced with testing, rather than bundled as a one-off change with other fixes. I'm happy going with black and isort across everything but it needs to be a project-level decision and then it needs to be maintained. That sound good? Want to create that issue @bolliger32 https://github.com/bolliger32?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RhodiumGroup/rhg_compute_tools/pull/76#issuecomment-660184263, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEUHFVUFBDSUVQ27JWYXZDR4BXWRANCNFSM4O5MAADQ .