switch bumpversion to setuptools_scm

RhodiumGroup / rhg_compute_tools

Tools for using compute.rhg.com and compute.impactlab.org

MIT License

1 stars 4 forks source link

switch bumpversion to setuptools_scm #81

Closed brews closed 4 years ago

brews commented 4 years ago

[x] closes #78
[x] tests added / passed
[x] docs reflect changes
[x] passes flake8 rhg_compute_tools tests docs
[x] entry in HISTORY.rst

We used to handle versioning with bumpversion, this PR switches it to setuptools_scm because it's better maintained.

In short, the package will share version with any commit you tag on. "dev" commits between tagged releases have a sensible default version.

delgadom commented 4 years ago

my hero! do we need to add setuptools_scm as a dependency to the travis build? I guess not because you include this in the setup_requirements?

brews commented 4 years ago

@delgadom, I think we're okay.

One thing I'm not sure about are cases that xarray is covering for, like here:

https://github.com/pydata/xarray/blob/98dc1f4ea18738492e074e9e51ddfed5cd30ab94/xarray/__init__.py#L33

and here:

https://github.com/pydata/xarray/blob/98dc1f4ea18738492e074e9e51ddfed5cd30ab94/setup.py#L5

...But I couldn't reproduce the problems these are working around.

Just something to keep in mind if we face an issue in the future if rct gets installed in some really weird way. I don't want to over-engineer this to avoid niche problems we'll never face.

delgadom commented 4 years ago

  # This is the case e.g. of a remote deployment with PyCharm Professional

😂 I think we're good here

delgadom commented 4 years ago

thanks @brews !