Closed delgadom closed 3 years ago
@bolliger32 I think this is good to go - feel free to merge on pass
Sure that’s fine with me
From: Ian Bolliger @.> Date: Friday, March 26, 2021 at 1:42 PM To: RhodiumGroup/rhg_compute_tools @.> Cc: Michael Delgado @.>, Author @.> Subject: Re: [RhodiumGroup/rhg_compute_tools] drop matplotlib rebuild() call in deign.init (#97) [EXTERNAL EMAIL]
@bolliger32 commented on this pull request.
Just one quick q on the history file
In HISTORY.rsthttps://github.com/RhodiumGroup/rhg_compute_tools/pull/97#discussion_r602575612:
+current version
+---------------
+
+Compatibility
+~~~~~
+
+* Drop matplotlib.font_manager._rebuild()
call in design.__init__
- no longer supported (:issue:96
)
+
v1.1.1 never actually built b/c of this CI issue, so should we add this under v1.1.1 instead?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/RhodiumGroup/rhg_compute_tools/pull/97#pullrequestreview-622520036, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA4G7UHV43IRPI2SLJVBJU3TFTWUDANCNFSM4Z4BZ3HA.
flake8 rhg_compute_tools tests docs
Updates:
design.__init__
. That does seem like a questionable strategy anyway. Note we still need to figure out how to enable rhg styles/fonts :(