search

RhostMUSH / trunk

RhostMUSH 4.0: This is the official main repository of RhostMUSH. Visit us at rhostdev.mushpark.com 4201
23 stars 21 forks source link

Switch relied on bangs and did not check if defined #122

Closed warmstarter closed 3 years ago

warmstarter commented 3 years ago

These two switch cases were causing errors when BANGS was not defined. Both of the cases relied heavily on BANGS.

IMPORTANT: Consider these #ifdefs as the markers for 'problem here' they may be all that's needed, but all of the various implications of this code are beyond my current understanding of the codebase.

Chalice commented 3 years ago

From what I can see, this would actually break functionality - it snufs the compile breakage but does not adjust the substitution's logics to a no-bangs alternative. See how it is done for the 'q' substitution to see how it should be handled. I'll implement it that way :)