search

RhostMUSH / trunk

RhostMUSH 4.0: This is the official main repository of RhostMUSH. Visit us at rhostdev.mushpark.com 4201
23 stars 21 forks source link

unused function warning #144

Closed warmstarter closed 2 years ago

warmstarter commented 3 years ago

This is on raspberri pi 2 debian buster

clang -g -DBROKEN_NDBM -DHAVE_ERRNO_H -DBIT64 -DMYSQL_VERSION=\"10.3.29\" -DC_SUB -DTINY_SUB -DLBUF32 -DQDBM -DSQLITE -DSBUF64 -DENABLE_WEBSOCKETS -DCRYPT_GLIB2 -DPCRE_SYSLIB -DSECURE_SIDEEFFECT -DPARIS -DBANGS -DMARKER_FLAGS -DZENTY _ANSI -DEXPANDED_QREGS -DREALITY_LEVELS -DATTR_HACK -DUSECRYPT -DSOFTCOM -DMUX_INCDEC -DTINY_U -DUSE_SIDEEFFECT -Wall -DHAS_OPENSSL -I/usr/include/mariadb -I/usr/include/mariadb/mysql -Wall -DMUSH_BUILD_DATE="\"cat date.txt\"" -DRW HO_IN_USE -DCACHE_OBJS -I../hdrs -c functions.c
functions.c:2292:1: warning: unused function 'arr2list_multi' [-Wunused-function]
arr2list_multi(char arr[], int alen, char list, char *listcx, char sep)
^
1 warning generated.

I'm guessing there's likely a #if that should go around this? but could be something else, haven't looked, just reporting found or now

warmstarter commented 3 years ago

functions.c deines:

ns_arr2list arr2list arr2list_multi

arr2list_multi does not appeared to be called anywhere in the source code. There's also:

list2arr newlist2arr list2arr_multi

list2arr_multi is also not used anywhere (though oddly this didn't generate a warning?)

Not sure if this old code not removed, new code not being used, or some gap in my C knowledge, but figured this info might help out a bit.

Chalice commented 3 years ago

It is, actually, new code that is not being used yet :) It's a generalized function that can (and someday will) be used to add multi-char delimiter support to some functions. I technically should comment it out to drop the warning until it is used, but yeh. New shiny by Ash. one of his last commits.

mrsenile commented 2 years ago

This has been commented out until it's being used.