search

RhysB / Project-Poseidon

A CraftBukkit CB1060 fork for Beta 1.7.3 fixing bugs and adding basic features
https://discord.gg/FwKg676
GNU General Public License v3.0
87 stars 30 forks source link

Commands can be hidden from being logged in console now #73

Closed MrMasrozYTLIVE closed 1 year ago

MrMasrozYTLIVE commented 1 year ago

Well the name should describe everything

ghost commented 1 year ago

Is it tested?

MrMasrozYTLIVE commented 1 year ago

image Tested it on uberbukkit with my own auth plugin. It works. Can test it again but on b1.7.3

MrMasrozYTLIVE commented 1 year ago

image image

MrMasrozYTLIVE commented 1 year ago

Beta 1.7.3 server ^ Poseidon jar used

RhysB commented 1 year ago

Apologies for the late reply.

This is a really good change. I only have one requested change, however.

Is it possible to keep the old hardcoded commands blocked? Just throwing this out there because most servers still use 2011-era auth plugins like AuthMe or XAuth. These plugins, as we know, don't have this feature and server owners probably won't rush to patch these plugins.

I get that it might take away a bit from the new feature, but I really think it's important that we keep player passwords from being logged and stored in plain text. It's a pretty big security issue.

MrMasrozYTLIVE commented 1 year ago

Is it possible to keep the old hardcoded commands blocked?

They are locked though. image

RhysB commented 1 year ago

Ahh, apologies for my mistake. Commit looks good to me.

Thanks for contributing :)