RhysSullivan / shiptalkers

https://shiptalkers.dev
677 stars 36 forks source link

Commit count seems to be off #43

Closed LTMenezes closed 4 weeks ago

LTMenezes commented 4 weeks ago

Hey, awesome project by the way!

The commit count seems to be way off for me, it counted 263 commits for me but I had more than 800 on 2018 alone. Link to my shiptalkers' page: https://shiptalkers.dev/compare?name=ltmenezes

Was it an issue because of the current load or is there any filter that I'm not aware of? E.g. only counts public repos owned by you.

timneutkens commented 4 weeks ago

(Disclaimer: I'm not the maintainer of this site) The tool only counts the last year, which is what is pulled from your GitHub profile it seems.

So contributions you did in 2018 are not counted, similarly it only looks at the last year of tweets, not all years of tweets.

raulillana commented 4 weeks ago

My commit count is also very low because of this. But counting the commits in private and organization repos would need authentication, and that will be a security / reliability issue probably…

Maybe GitHub should make those data available in some way through the API. 😅

LTMenezes commented 4 weeks ago

Thanks @timneutkens, that makes sense!

I will close the issue for now then, cheers.

timneutkens commented 4 weeks ago

@raulillana there's some option on your GitHub profile page when logged in to include private contributions in your contribution graph, i.e.: CleanShot 2024-06-06 at 12 53 58@2x

raulillana commented 4 weeks ago

@timneutkens yeah, had it active for like a decade, thanks. Does it scrape from the graph or from the API then?