RhysSullivan / shiptalkers

https://shiptalkers.dev
677 stars 36 forks source link

Add: Tagnames for the user after comparing #76

Open amitjimiwal opened 3 weeks ago

amitjimiwal commented 3 weeks ago

``Closes

image

vercel[bot] commented 3 weeks ago

@amitjimiwal is attempting to deploy a commit to the rhyssullivan's projects Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shiptalkers ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 10:43am
RhysSullivan commented 3 weeks ago

Thanks for opening this PR! I deployed it so you can see it with prod data

https://shiptalkers-git-fork-amitjimiwal-tagline-rhyssullivans-projects.vercel.app/compare?github=ndavd&twitter=0xndavd

Looks like that may be incorrectly marked as perfectly balanced?

RhysSullivan commented 3 weeks ago

Indie hackers also might be good to swap out for "founder" if it's >100k followers I.e https://shiptalkers-git-fork-amitjimiwal-tagline-rhyssullivans-projects.vercel.app/compare?name=karpathy

amitjimiwal commented 3 weeks ago

Yes , I just swapped it for founder if follower > 100k. I have added search param follower in api/og/compare route for reflecting changes in the image.

RhysSullivan commented 3 weeks ago

thanks, im finishing a major feature then i'll take a look

amitjimiwal commented 3 weeks ago

Hey @RhysSullivan , just updated the tags on the cofounders and other pages. Can you check it out ?. Do lemme know the changes req.

amitjimiwal commented 3 weeks ago

@RhysSullivan any updates ?