Closed sriki18 closed 2 years ago
@keenanjohnson not sure if you had a look!
I did see it but haven’t gotten a chance to take a look! I’ll get to it soon! Thanks for the contribution!
On Sat, Oct 9, 2021 at 6:44 PM Srikiran Chandrasekaran < @.***> wrote:
@keenanjohnson https://github.com/keenanjohnson not sure if you had a look!
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Ribbit-Network/ribbit-network-dashboard/pull/52#issuecomment-939389871, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATQ3FUTAXQLPAKGIWXNROTUGDVWZANCNFSM5FURFKVA .
Thanks @sriki18 !
What do you think about adding a second y-axis to the temperature and pressure plots, so we can see the measurements in different units?
So we would retain the current "scientific/metric" units on the left, then add another axis with alternate units on the right (old-fashioned US/Imperial units).
(@keenanjohnson I can help review this PR if I had the permissions to assign myself as reviewer)
Oh sure thing @spestana ! I can add you! Seems like this PR has gone a bit stale if you want to help push it along :)
I can do that, should it be a branch once this branch has been merged? @keenanjohnson @spestana
@sriki18 can you see my comment in the review previously about the read-ability?
@spestana done. Have a look!
Use Plotly's
add_trace
instead of Plotly express to plot the timeseries while converting it from a list of plots to one figure with subplots. Plots now share X axis, so zooming in one will also zoom in the others. Fixes #30