Ribbit-Network / ribbit-network-dashboard

The web dashboard for the world's largest crowdsourced network of open-source, low-cost, CO2 Gas Detection Sensors.
MIT License
17 stars 16 forks source link

remove shared-xaxes to set time on each table; update README with an … #99

Closed jklmaynard closed 1 year ago

jklmaynard commented 1 year ago

As noted in the issue for this PR, this is just removing the shared_xaxes parameter that set all graphs to share one time x axis. Removing that installs the x axis for each graph.

I also updated the README to help those of us less savvy with python installations, who might hit a issuer cert error.

keenanjohnson commented 1 year ago

Thanks for fixing this @jklmaynard ! I've confirmed that running your PR locally the axis are now visible.

image

The only downside of this approach is that if you zoom in on one of the graphs, not all of the graphs zoom into the same scale as they did previously (image below shows the new behavior where the timescales don't match). Do you know @jklmaynard if that is just a usability choice we will have to make or if there is a way to keep the shared zoom behavior, but display the timescales on each graph. It's ok if that's the choice we need to make, but just asking if you were aware / had explored before?

image
jklmaynard commented 1 year ago

@keenanjohnson yeah, once the x-axis is decoupled, any zooming in on any graph is going to be only on that graph. The only way around that would be to derive some kind of listener for zooming in, but I'm not sure if that's available through the API. It could be pretty messy, and not worth it.

keenanjohnson commented 1 year ago

I see! Thanks for clarifying @jklmaynard !

@pascaljoly since you were the one that originally reported this issue, what are your thoughts? Would you prefer to give up the shared zooming behavior for the addition of the extra timescales?

keenanjohnson commented 1 year ago

Thanks @pascaljoly !