search

Ribbit-Network / ribbit-network-frog-hardware

The sensor for the world's largest crowdsourced network of open-source, low-cost, GHG Gas Detection Sensors.
https://www.ribbitnetwork.org/
MIT License
94 stars 26 forks source link

Corrected balena.yml #118

Closed wjlove closed 2 years ago

wjlove commented 2 years ago

The correct device type for BBG Wireless is beaglebone-green-wifi.

After reviewing the balena officially supported hardware list the name for the Beaglebone Green Wireless is not beaglebone-green-wireless but rather beaglebone-green-wifi. I apologize for the error.

keenanjohnson commented 2 years ago

Hey there @wjlove ! Thanks for the correction, but it looks like some other edits to the readme made it into this PR on accident?

wjlove commented 2 years ago

Oh.... I hope I didn't screw up your readme file. I've been having problems understanding how this all works and looks like one of the applications I have been learning (Ghostwriter) autosaves things in the wrong place. Actually I guess I am using it wrong.... Do you need me to back out the PR and try again with a heightened attention to detail?

What a learning experience, sorry you are on the receiving end of all the mistakes.

keenanjohnson commented 2 years ago

No worries at all! This is what open-source is for, a learning experience! And no worries about messing anything up. That's why we do this PRs with reviews to double check each other before pushing changes to the bigger project.

If you check out the "Files Changed" section of the PR, you can see that you edited the Readme and added a new backup readme file.

If you make a new commit undoing those changes and push it to this PR, then we should be all good.

wjlove commented 2 years ago

So after some reading I think I did this correctly. I've made a second commit with the readme.md.backup removed and the original readme.md restored. Before I press any buttons, flip any switches, or turn any knobs I want to be sure I have done the correct thing(s).