search

Ribbit-Network / ribbit-network-frog-hardware

The sensor for the world's largest crowdsourced network of open-source, low-cost, GHG Gas Detection Sensors.
https://www.ribbitnetwork.org/
MIT License
93 stars 26 forks source link

Updated Lid V4 part file #221

Closed eaudiffred closed 1 year ago

eaudiffred commented 1 year ago

New lid part file. Decreasing the tolerance on the lid so that it is not loose.

keenanjohnson commented 1 year ago

Hey @eaudiffred ! The new part looks good and this PR also looks good as there is only the one part that is changed.

image

As we discussed in email, it's a bit confusing that there are so many unrelated commits shown in the history of your branch like this:

image

This can be resolved next time if you sync your fork before beginning the work. The instructions for that can be found here: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork. Let me know if that doesn't help or doesn't make sense :)