Ribbit-Network / ribbit-network-frog-software

The software for the Ribbit Network Frog Sensor
https://www.ribbitnetwork.org/
MIT License
9 stars 8 forks source link

WIP: network refactoring #32

Closed damz closed 1 year ago

damz commented 1 year ago

Objectives

keenanjohnson commented 1 year ago

This looks awesome @damz ! It looks to me in a quick read like the connection type is driven by the configuration settings.

One additional thought / improvement I was considering.

Do you think it's possible / would it make sense to have some sort of auto connection hierarchy that would remove the need for the configuration depending on what settings are configured / what hardware is available? The benefit of this is that for users building the Frog kit with a cellular modem, they wouldn't have to use Curl / a command line tool to change the network config.

I am imagining for example the priority would be:

  1. Ethernet
  2. Wifi
  3. Cellular

So the algorithm in my head would be:

keenanjohnson commented 1 year ago

@damz I am planning on taking this over. Was there any known outstanding work or issues when you left it?

keenanjohnson commented 1 year ago

Moving to a new PR so I can take this over: https://github.com/Ribbit-Network/ribbit-network-frog-software/pull/39.

@damz if you have any memories of what the state of this was when you left it, that would be immensely helpful so I know where to start. Really appreciate it!