search

Ribbit-Network / ribbit-network-frog-software

The software for the Ribbit Network Frog Sensor
https://www.ribbitnetwork.org/
MIT License
9 stars 8 forks source link

sensors: Add scd30.force_calibration remote command #52

Open damz opened 7 months ago

damz commented 7 months ago

This PR adds a scd30.force_calibration RPC command that forces a calibration of the SCD30 CO2 sensor, in addition to the infrastructure necessary to allow sensors to implement commands.

keenanjohnson commented 7 months ago

Great use of the golioth commands. This is certainly a power-user type feature, but I think it's good that it's there.

It might be a good idea to log or record somewhere that the FRC was issued in some way ( and ideally perhaps what the frc value was? I don't think the sensor exposes that but perhaps the previous sensor value is good enough).

That way someone looking at analysis could distinguish which sensors had an FRC vs ASC.