Ribbit-Network / ribbit-network-frog-software

The software for the Ribbit Network Frog Sensor
https://www.ribbitnetwork.org/
MIT License
9 stars 8 forks source link

ribbit.sensors: Fix SCD30 initialization sequence #53

Closed damz closed 7 months ago

damz commented 7 months ago

Because we don't await on these coroutines, they never get the chance to be executed, so the measurement interval and the self-calibration settings are never set.

keenanjohnson commented 7 months ago

Ah makes sense and good catch.

I wonder if we can in the future use a static analysis tool or the simulator in CI to ensure that the init parameters actually are sent to the hardware.