Closed damz closed 7 months ago
It looks like code size went down ~2.7 kB
, which is a nice side effect.
The cloud function that converts the JSON into influx DB is here for reference: https://github.com/Ribbit-Network/SensorDataToInfluxDB/blob/main/main.py
Looking at the JSON diff, it seems that everything should be fine to me.
Have you tested this on hardware yet @damz ?
@keenanjohnson I confirmed that the UI still works and that the "aggregate" payload logged in the serial console is OK. I haven't confirmed that it works end-to-end.
Looks good to me!
The original idea was to use the
export()
method on each sensor class to generate the export data, but with the introduction of the backwards-compatible "aggregate" data, that method became unused.Refactor and clean-up:
export()
method on the sensor classes to generate the aggregate export dataexport()
method on the sensor classes to generate the websocket export data_static.py
module on build instead of committing it in the repositoryData format change
Here are the changes to the "aggregate" data payload after this change. Nothing has changed that I expect the import lambda to care about.