Ribosome25 / Traditional_Transfer_Learning

6 stars 2 forks source link

Confusion about your SDA implement #1

Open s0rel opened 4 years ago

s0rel commented 4 years ago

Hi, I'm reading SDA paper. http://www.bmva.org/bmvc/2015/papers/paper024/paper024.pdf And I find your great work,but I'm a little confused about some lines of your code.

var_ratio = np.diag(np.multiply( np.power(pe_S,-0.5), np.power(pe_T,0.5) ))
Ms = np.dot( np.dot( np.dot(pc_S.T,pc_S) ,pc_T.T) , var_ratio )
Mt = pc_T.T
newS = np.dot(Xs , Ms)
newT = np.dot(Xt , Mt)

I think the target domain can't not be modified.

Ribosome25 commented 4 years ago

Hi S0rel, thanks for the comment. I'll look into this issue.

zackxconti commented 2 years ago

Hi, thank you for sharing the code to your paper.

I am a little confused why: Mt = pc_T.T ?

Thank you!