RicardoRamirezR / blade-nav.nvim

Navigating Blade views within Laravel projects
MIT License
37 stars 4 forks source link

Treesitter main branch support #23

Closed alanfzf closed 2 weeks ago

alanfzf commented 3 weeks ago

Does this plugin support the main tree-sitter branch? as i get a bunch of errors, when trying to navigate the blade files.

image

RicardoRamirezR commented 3 weeks ago

Good day @alanfzf,

Yes it does.

https://github.com/user-attachments/assets/a25ce1e3-e8f6-494e-8a31-a107d7690bef

Please provide :checkhealth blade-nav output

alanfzf commented 3 weeks ago

Hey there @RicardoRamirezR, thanks for your reply, here's some stuff i tested:

Sharing checkhealth image

image

Just to be 100% clear, when i meant main tree-sitter branch, i meant the new one (main) not master, it seems they made some breaking changes so that's why im asking.

image

RicardoRamirezR commented 3 weeks ago

@alanfzf I understood better now.

The current treesitter i'm using is:

Screenshot 2024-08-21 at 4 32 23 PM

But I changed to main and I can not reproduce it 😏

alanfzf commented 3 weeks ago

Oh i see, let me switch to the master branch, i will get back to you later tonight 👍🏻

RicardoRamirezR commented 3 weeks ago

@alanfzf please check main, at least will not generate the error on treesitter main

alanfzf commented 3 weeks ago

Hey there @RicardoRamirezR , could not get back to you yesterday, but i switched to master branch on treesitter and everything seems to be working fine now, just a little side note, i had to delete my .local/share/nvim folder to correctly test the behavior, as when i just switched normally without a clean install it still failed on master branch, it seems like there's a breaking issue on the newest (main) branch.

Oh and also checked with your newest commit and tree-sitter on main and sadly it stills fails 🥲.

EDIT: checking a pinned issue on the neovim repo, it seems they dropped the support for module framework I'm not really well versed, on tree-sitter but if your plugin somewhat depends on the module framework it may be the cause

RicardoRamirezR commented 2 weeks ago

@alanfzf I see. I'm not versed in the subject either. So when the time comes I will address it if possible.