search

Rice-Comp413-2016 / RDFS

The Rice Comp413 class (2016-2017) implementation of HDFS. (This will eventually be put under an open source license, which one TBD).
4 stars 2 forks source link

Delete and Abandon Block #99

Closed Swyrough closed 7 years ago

Vegetable26 commented 7 years ago

Is there a end-end integration test for this? I think it'd be cool merging this in, if ReplicationTest is untouched

Swyrough commented 7 years ago

idk how to respond to ur comment @Vegetable26 . once upon a time there was an integration test, this most recent commit involved me making a multiblock file on two datanodes and then deleting the file and checking for all the proper things myself. ReplicationTest is untouched. Deletes and abandon blocks are 'supplementary' i guess...no demo depends on them.

nichhk commented 7 years ago

LGTM

Vegetable26 commented 7 years ago

I guess I was saying if ReplicationTest still works we should push :) It would be nice to have a test where we write a file and delete it 10 times. Just to make sure all the meta information is gone. And if we used a large file ~500 MB, to see if the DataNode is actually freeing up disk space. But in the sake of going fast, let's just merge 👍