RiceMunk / omnifit

This is a package for doing ice spectroscopy fitting of interstellar ices.
https://ricemunk.github.io/omnifit/
6 stars 5 forks source link

test_fittheory has started failing #30

Closed RiceMunk closed 6 years ago

RiceMunk commented 7 years ago

Seems like one of the unit tests has started failing at some point. The following bit specifically seems to be raising an exception: testfitter.add_analytical('gaussian',testpars,funcname='test gaussian') testfitter.perform_fit() Fails with "fitting failed".

My guess: something has changed with lmfit which makes it not behave with omnifit. Should look into this when have time.

RiceMunk commented 6 years ago

test_fittheory was actually pretty awfully written in the first place and was fitting nonsense to its spectrum. That it hadn't failed originally is pretty much providence of a merciful fitting algorithm thinking it converged to something useful.

Fixed the test in the branch "fix-old-stuff" to make it a bit less dumb.