Rich-Harris / butternut

The fast, future-friendly minifier
https://butternut.now.sh
MIT License
1.17k stars 17 forks source link

add yet another webpack plugin #124

Closed MaxGraey closed 7 years ago

MaxGraey commented 7 years ago

With supporting async batching

balthazar commented 7 years ago

What's the point of duplicating things exactly?

MaxGraey commented 7 years ago

Different implementation

MaxGraey commented 7 years ago

For example:

const ButternutWebpackPlugin = require('butternut-webpack-plugin').default;

vs

const ButternutPlugin = require('webpack-butternut-plugin');
balthazar commented 7 years ago

Comparing the require is not an impactful improvement.

Any benchmarks? PRs exists for a reason too.

MaxGraey commented 7 years ago

@Apercu Actually I started of working one week ago and your implementation I find out only today. Anyway I don't see a problem for example webpack's UglifyJS plugin has three different implementation as minimum.

Benchmark will be later with Closure and Uglify competitors