Rich-Harris / dts-buddy

WORK IN PROGRESS DO NOT USE
MIT License
317 stars 12 forks source link

feat: support stripping internal types #87

Closed dummdidumm closed 2 months ago

dummdidumm commented 2 months ago

... using @internal JSDoc tags, if the stripInternal tsconfig compiler option is enabled. This means types annotated with @internal will be stripped both from .js/ts files going through the TS program aswell as d.ts files going through our logic

part of https://github.com/sveltejs/svelte/issues/12292

fixes #63

dummdidumm commented 2 months ago

I have no idea what's going on with CI, but all tests passed locally for me (maybe someone with a non-windows system should run them too, just to make sure)

Rich-Harris commented 2 months ago

it seems unrelated to the PR — passed for me locally too. maybe we just try again tomorrow?

image
dummdidumm commented 2 months ago

No idea why the setup action was pinned to an old version - that was the problem, there was an error fixed in a later version of 2.x recently, but I don't see a reason to not just bump to v4 instead.

Anyway, this is good to go now.

Rich-Harris commented 2 months ago

published! great addition