search

Rich-Harris / pancake

Experimental charting library for Svelte
MIT License
1.29k stars 61 forks source link

InternalError: too much recursion with 0.0.16 #23

Open mattiash opened 4 years ago

mattiash commented 4 years ago

When I upgraded my own application with pancake from 0.0.15 to 0.0.16, the application stopped working and showed

InternalError: too much recursion

in the console. The page at https://pancake-charts.surge.sh/ does not show the same problem (is it running 0.0.16?), but if you click Edit on the "Life Expectancy" graph, the repl (which is using 0.0.16) shows the same problem:

Uncaught DOMException: The object could not be cloned. srcdoc:130
Uncaught DOMException: The object could not be cloned. srcdoc:134
Uncaught (in promise) InternalError: too much recursion
    add about:srcdoc line 86 > eval:3630
    add about:srcdoc line 86 > eval:3656
    add about:srcdoc line 86 > eval:3649
    add about:srcdoc line 86 > eval:3656
...

The above error is from firefox. Safari shows a similar Unhandled Promise Rejection: RangeError: Maximum call stack size exceeded.

ashpil commented 3 years ago

Can confirm this also occurs in Chrome. This appears to break the interactivity of the life expectancy graph.

MarceloPrado commented 3 years ago

Take a look at #27, it fixes the recursion issue

jonhuang commented 3 years ago

I ran into the same issue and @MarceloPrado's branch fixed it for me. Thank you!