search

Rich-Harris / svelte-knobby

MIT License
201 stars 16 forks source link

Update to support latest kit version #29

Open jpaquim opened 2 years ago

jpaquim commented 2 years ago

Update dependencies to latest version. The resulting package should be compatible with the latest SvelteKit version.

jpaquim commented 2 years ago

Fixes https://github.com/Rich-Harris/svelte-knobby/issues/28 from my tests. I was facing a few issues with pnpm's handling of the yooutils and other dependencies, needed to shamefully hoist those to work correctly.

braebo commented 2 years ago

Thanks for this! Would love to be able to use this with svelte-kit. When I try to install your fork, I get this error when importing svelte-knobby:

> Build failed with 1 error:
node_modules/.pnpm/vite@2.8.6_sass@1.49.9/node_modules/vite/dist/node/chunks/dep-9c153816.js:29537:10:
ERROR: [plugin: vite:dep-scan] Failed to resolve entry for package "svelte-knobby". The package may have incorrect main/module/exports specified in its package.json: Failed to resolve entry for package "svelte-knobby". The package may have incorrect main/module/exports specified in its package.json.

Should I fork your fork and build it first if I want to use it?

jpaquim commented 2 years ago

Hey @FractalHQ! Yes, I'm basically including my fork as a git submodule and building it locally before my svelte-kit builds. You can check out either https://github.com/jpaquim/svelte-webgl-fluid-simulation or https://github.com/jpaquim/svelte-webgpu for examples of usage.

I'd assume that when integrated upstream (this repo) this manual build process won't be necessary anymore, but there still may be some details I'm overlooking...