search

RichGuk / deluge-in-chrome

Provides quick overview of torrent information in Chrome for the torrent client Deluge.
https://chrome.google.com/extensions/detail/pbenannnhhgfhhijhlpgfbjagebjeeel
MIT License
16 stars 16 forks source link

Support Magnet Links #15

Closed ghickman closed 12 years ago

ghickman commented 12 years ago

The Pirate Bay has moved to only using magnet links, other sites might go that way.

However many sites have supported magnet links for a long time, so it would be useful to support them.

I suspect the easiest way would be to expand on the functionality that picks up the download links do the same to magnet links there.

RichGuk commented 12 years ago

Agreed. @chvckd also mentioned the need to support magnet links, I was going to look at this when I tried to add private tracker support. I'll get my arse into gear and look at it this week, if I get time.

ghickman commented 12 years ago

Brilliant, cheers. Can lend a hand if needed.

chvck commented 12 years ago

Yeah I was planning on adding this too. We could use the same icon approach which may look odd if both torrent and magnet icons are turned on and displayed together or we could make a 1 click link function for magnet links. We could just do both and throw them in the options menu...

ghickman commented 12 years ago

oops - way more keyboard shortcuts on her than I realised…

ghickman commented 12 years ago

@chvckd it could always be a modified icon that includes a magnet in some way?

chvck commented 12 years ago

@ghickman yeah that could work too I guess. This is only going to work on deluge 1.4 up, the web ui itself doesn't actually work for magnets until that version i think

ghickman commented 12 years ago

@chvckd it's in 1.3.4 according to these two:

chvck commented 12 years ago

Ah ok cool, I'm on 1.3.1 and that's why it doesn't work for me. Shall upgrade and have a play!

chvck commented 12 years ago

Added to code base, will be included in next release.

RichGuk commented 12 years ago

So, is 1.3.4 a released version of Deluge? If not should we release and add a requirement to this extension when 1.3.4 is released?

Or would the better approach be, especially as we've maintained backwards compatibility so far, to only enable magnet links if we detected Deluge version >= 1.3.4

chvck commented 12 years ago

I was just thinking that myself, only enable if 1.3.4 is detected. 1.3.4 is not released and from what I can see doesn't have a release date either. If you're running 1.3.3 do a pull and see what happens if you try use magnet stuff? Who knows it might randomly work!

ghickman commented 12 years ago

Detecting the version of Deluge seems the nicest way to go.

Could make it an option in the prefs that only appears with Deluge >= 1.3.4? If you go down that route it would be nice to give the option of which download style to enable. Tick boxes by both would work so you could have none, either, both enabled.

chvck commented 12 years ago

That is how it's been set up, tick box for each, will just need to add the detection .

chvck commented 12 years ago

This has been added in the form of 1 click links on magnet links and also auto-detection within the context menu and manual add. Closing issue as any bugs should be tracked in a separate issue.