Closed ssokolow closed 12 years ago
Yeah, I've noticed on a few sites it messes the layout up slightly, there is also an issue when trying to access private trackers, as deluge doesn't have the login cookie.
I do not think an overlay on a text link will work very well. However the onClick suggestion might work, I'll take a look at the chrome API's and see if any context menu support stuff has been added yet! It hadn't when I first looked, hence why I didn't go down that route.
Requiring a context menu would drop me as a user anyway. As a result of current Chrome's decision to remove "http://" from the URL bar and reorganize the buttons, having still not added a checkbox or config file line to re-enable single-click URL select on Linux, I've decided to freeze my Chromium at 5.0.342.7.If someone forks it to patch in some "put it back" config toggles, I'll un-freeze.
Otherwise, I'll just stay on this version until Firefox delivers a GUI that is actually useable with more than one tab on Linux.
As for an overlay on text, there are other options that can be considered.
I love the idea of an onClick handler. I have no clue what options for link handling are available in Chrome. The Bittorrent WebUI extension for Firefox had the best implementation for link handling in my opinion, but whether these features can transfer into Chrome is out of my knowledge level. See http://www.alexisbrunet.com/ for info on the extension. If there is no better way to address link handling in Chrome, an add torrent text box within the extension's UI would be helpful. Ideally, one would copy a torrent or magnet link, click the extension icon, paste the link into the box, and click a button to add the torrent. It still requires copy/paste operations, but it would save the users from going through the main WebUI to add torrents, and thus speed up the process slightly.
After discussions we have decided to not add functionality to override the onClick behaviour of links and to keep the existing option of having an icon added. In the next release we have also added an option to add a "Add to Deluge" context menu and functionality to manually add a torrent via entering an url into the overlay.
At least there will be some sort of option to avoid distorting the page.
About a year ago, I got fed up with how crippled and poorly-organized Chrome's configuration options are and switched to Firefox, so it's not a big deal to me either way.
The current "add a new icon" approach to the "download in Deluge" links can throw off site layouts and doesn't really look very good when a site provides multiple download links. (eg. btjunkie.org)
My suggestion would be to just attach an onClick handler to detected torrent links so users can simply click the existing torrent links to download in Deluge or right-click to access the normal behaviours.
If you really want to provide a visual notification that your extension found a torrent link, why not use some CSS positioning trickery to overlay the Deluge icon on the bottom-right corner of the link. (Sort of like the emblems that you can stick on files and folders in Linux file managers like Nautilus)
If you want an example of how Nautilus overlays emblems on the top-right, there's a screenshot at http://wiki.creativecommons.org/images/9/91/Ll_nautilus_emblem.png
It'd also be nice if the extension redirected magnet links to Deluge so I didn't have to copy and paste them.