search

RichGuk / deluge-in-chrome

Provides quick overview of torrent information in Chrome for the torrent client Deluge.
https://chrome.google.com/extensions/detail/pbenannnhhgfhhijhlpgfbjagebjeeel
MIT License
16 stars 16 forks source link

Requesting "Remove" button in the Browser Action pop-up #5

Closed ssokolow closed 14 years ago

ssokolow commented 14 years ago

Having used Deluge in Chrome for several downloads, I've realized that, aside from an Open/Preview option, the one thing I really miss about the GTK+ Deluge GUI is a quick-access Remove button. (The full WebUI's one doesn't count because it's slow to load and ExtJS makes for a laggy GUI)

My suggestion would be:

  1. Add an X icon (blue-recolored copy of the Remove icon in the full web UI?) to the panel of per-torrent actions.
  2. When clicked, the X icon replaces all cells to the right of the title with a single colspanned element.
  3. The single colspanned element contains "[Cancel] [Remove with Data] [Remove Torrent]"
  4. Clicking Cancel or closing the browser action pop-up returns the row to its original state

That'd satisfy the following requirements:

  1. Confirmation before anything gets deleted.
  2. No more than two clicks and no laggy waiting between them
  3. Intuitive association between the pseudo-dialog and the torrent it affects
  4. Appropriate behaviour on pop-up close

If you're too busy, there's a chance you'll receive a merge request from me in May once my vacation has started... but I'm not very good at keeping "...on my vacation" promises, so no guarantees.

RichGuk commented 14 years ago

Sounds like a plan, I'll begin working on this - I've been after the delete feature too. I can already vision one side-effect, I'll have to pause the torrent listing update why the delete options are displayed, basically I refresh the entire table contents every few seconds so you'll see the options and then they'll be refreshed.

ssokolow commented 14 years ago

Sounds like a fair trade-off, given the hassle of the alternative. (pulling the table from the remote end, manually breaking out the bits of info, and then injecting them individually into the modified table as necessary)

RichGuk commented 14 years ago

Hey, I've just pushed the delete functionality - if you wish to test it before I make the new version of the extension live tomorrow, backup torrent data before just incase though :)

Cheers,

Rich

ssokolow commented 14 years ago

I think I'll abstain. Too much exam studying to do right now.

RichGuk commented 14 years ago

No problem dude, I'll do some more testing myself - good luck with the exams.

RichGuk commented 14 years ago

Published, closing ticket.