RichJackson / cogstack

Database - Elasticsearch realtime mapping. With NLP goodiness.
Apache License 2.0
7 stars 2 forks source link

Extract page count, Timing for tika/pdf/thumbnail generation, Improve error handling and logging in PDFFileItemWriter #23

Closed hkkenneth closed 7 years ago

hkkenneth commented 7 years ago

Sorry for the mess - needed to PR the integration branch because there was conflicts to resolve.

Separated branches can be found at KHP-Informatics repo.

RichJackson commented 7 years ago

No worries - lets catch up Thurs to talk about the other issues you raised

Sent from Yahoo Mail on Android

On Mon, 14 Nov, 2016 at 17:01, Kenneth Luinotifications@github.com wrote:
Sorry for the mess - needed to PR the integration branch because there was conflicts to resolve.

Separated branches can be found at KHP-Informatics repo.

You can view, comment on, or merge this pull request online at:

  https://github.com/RichJackson/turbo-laser/pull/23

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

RichJackson commented 7 years ago

Just reviewed the code for this. Looks good, but can you write a test to verify?

hkkenneth commented 7 years ago

Test is included in the latest PR #31 because the branches have diverged during the past few months.