search

RichSteini / WeakAuras2-TBC-2.4.3

GNU General Public License v2.0
9 stars 9 forks source link

Swing Timer - Attack Mod abilities aren't registered. #10

Closed Foodlenz closed 1 year ago

Foodlenz commented 1 year ago

Describe the bug

When using an ability that modifies the next melee attack (heroic strike, cleave, raptor strike, maul, etc.) the swing timer doesn't register it as a melee swing and so the swing timer wont reset until the next white swing.

https://user-images.githubusercontent.com/72258441/224519017-78935abb-9463-4c14-9785-9ee440cd70b8.mp4

https://user-images.githubusercontent.com/72258441/224519019-00672db7-a0a8-4423-aa24-33e06c349386.mp4

RichSteini commented 1 year ago

SWING_DAMAGE or SWING_MISSED CLEU does not fire when you use a queue ability like the ones mentioned. I have to add them manually, are there any others than heroic strike, cleave, raptor strike, maul?

RichSteini commented 1 year ago

Implemented for heroic strike, cleave, raptor strike, maul in Fix melee swing timers for queued spells, e.g., Heroic Strike. Another question is, do all of these spells work on mainhand and offhand swings?

Foodlenz commented 1 year ago

All of them should only work with the main hand swing.

RichSteini commented 1 year ago

I improved it in Swing timer improvement, spellId lookup table with spellIds so it also works on clients with other languages. Dual wielding is still not perfect, but you cannot make it better on the 2.4.3 client, since everything is just with timings.