RichSteini / WeakAuras2-TBC-2.4.3

GNU General Public License v2.0
9 stars 9 forks source link

Aura Missing Trigger #11

Closed Foodlenz closed 1 year ago

Foodlenz commented 1 year ago

Describe the bug

The Trigger -> Aura -> Show if Missing trigger doesn't check for the aura on initialization is seems. I have this one set to only show in Combat. Sometimes it'll check again shortly after I enter combat and vanish, other times it'll just stay put being active the whole time when it shouldn't be.

image

https://user-images.githubusercontent.com/72258441/224525887-d6437f59-bda9-487e-b1e8-3e2e4297e267.mp4

RichSteini commented 1 year ago

With on initialization you mean, after you close the weakauras option window or after you log in? I can't reproduce this, for me it seems to work normal.

Foodlenz commented 1 year ago

I mean since I have that aura set to only load in combat. I figured it worked like the Actions tab where it'd fire a check OnLoad or whatever. Which if it did, it would see that Battle Shout was already applied, and so wouldn't trigger the weakaura to fire the reminder to apply battle shout on my screen.

But if it works correctly for you, maybe it's another addon causing issues. I'll try it again when i get home tonight and check if that's the case.

RichSteini commented 1 year ago

I tested everything through and it is working as expected for me. If i am out of combat then it does not show at all, does not matter if applied or not. If i enter combat and have it already applied then it does not show up and if i enter combat and i do not have it applied then it shows up instantly, and when i apply it while combat then it vanishes. Maybe try with other addons disabled then.

RichSteini commented 1 year ago

Someone reported the same problem and figured out that it is caused by SpeedrunSplits https://github.com/RichSteini/WeakAuras2-TBC-2.4.3/issues/13. Are you using that too?

Foodlenz commented 1 year ago

I was, yeah. Didn't get a chance to test addon conflicts last night, but probably that.

RichSteini commented 1 year ago

Yes, we fixed SpeedrunSplits so it does not break WeakAuras anymore. Macumba will update the addon in the next few days. Closing this as it seems to be solved.