RichSteini / WeakAuras2-TBC-2.4.3

GNU General Public License v2.0
9 stars 9 forks source link

Createing Progress Texture with Oriantation Erroring out #18

Open MartMlr opened 1 year ago

MartMlr commented 1 year ago

Describe the bug

When I'm trying to create a progress-texture and set the orientation to clockwise or counterclockwise, then Weakaura errors out.

Additional Info

WeakAuras-4.0.0\RegionTypes\ProgressTexture.lua:288: attempt to call method 'CreateAnimationGroup' (a nil value)
WeakAuras-4.0.0\RegionTypes\ProgressTexture.lua:362: in function `SetProgress'
WeakAuras-4.0.0\RegionTypes\ProgressTexture.lua:692: in function `orientCircular'
WeakAuras-4.0.0\RegionTypes\ProgressTexture.lua:736: in function `modify'
WeakAuras-4.0.0\WeakAuras.lua:2575: in function `SetRegion'
WeakAuras-4.0.0\WeakAuras.lua:2460: in function <Interface\AddOns\WeakAuras\WeakAuras.lua:2351>
WeakAuras-4.0.0\WeakAuras.lua:2497: in function `Add'
WeakAurasOptions-4.0.0\DisplayOptions.lua:181: in function <Interface\AddOns\WeakAurasOptions\DisplayOptions.lua:170>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[2]":9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?:
AceConfigDialog-3.0\AceConfigDialog-3.0.lua:818: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:639>
...:
<string>:"safecall Dispatcher[3]":9: in function <[string "safecall Dispatcher[3]"]:5>
(tail call): ?:
AceGUI-3.0\AceGUI-3.0.lua:318: in function `Fire'
...as\Libs\AceGUI-3.0\widgets\AceGUIWidget-DropDown.lua:442: in function <...as\Libs\AceGUI-3.0\widgets\AceGUIWidget-DropDown.lua:433>:
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[3]":9: in function <[string "safecall Dispatcher[3]"]:5>
(tail call): ?:
AceGUI-3.0\AceGUI-3.0.lua:318: in function `Fire'
...s\AceGUI-3.0\widgets\AceGUIWidget-DropDown-Items.lua:351: in function <...s\AceGUI-3.0\widgets\AceGUIWidget-DropDown-Items.lua:341>:

  ---
MartMlr commented 1 year ago

grafik

MartMlr commented 1 year ago

Helpful ressources for potential fix: https://wowpedia.fandom.com/wiki/API_AnimationGroup_CreateAnimation https://github.com/martinjlowm/AnimationGroup

RichSteini commented 1 year ago

I have been taking a look at it and i don't think it is possible to fix this. Took quite a while for me to even understand what he is doing there. So just as an explanation, suppose we choose a clockwise rotation: What he is doing is he rotates the texture clockwise while rotating the region of the texture counterclockwise. The cooldown edge comes from moving the texture out of scope of the region while rotating the whole region in the other direction. Rotating a region is also the only way to get a cooldown edge at an angle. The problem in 2.4.3 is that we can only rotate the texture, but we cannot rotate the region.

RichSteini commented 1 year ago

Options removed and commented the animationgroup part, because it bricks WeakaurasOptions: Remove clockwise/anticlockwise progress texture options (bricks WA)