BUFF trigger own Only is not working

[jiaweigang]

Describe the bug

BUFF trigger own Only is not working properly

Which version of WeakAuras are you using?

4.0.2

[RichSteini]

First of all, your report is absolutely pointless if you are not more specific. Describe the problem properly and back it up with reproducible material like videos. Also disable all other addons while testing it. I tested it and it worked for me, that is what i can say from my side.

[jiaweigang]

https://github.com/RichSteini/WeakAuras2-TBC-2.4.3/assets/37294342/b7200e6b-daaa-4837-b17d-82b4fb73e823

I tested that it did not work properly, Is this feature related to the server implementtation. machine translation excuse me

[Nuy]

I can confirm this. I tried making multi-DoT tracking weak aura group and when "Own Only" is checked the WA won't work. Same with something like this - https://wago.io/Iyo_Jev7d. Works perfectly fine only if "Own Only" option is disabled but if it's on it doesn't work.

[jiaweigang]

I tested it again, when "Own Only" is checked the WA won't work, "Own Only" option is not checked or Not from myself BUFF trigger works. There should be some issues with the judgment logic. Excuse me, my English is poor.

[RichSteini]

Ok i did not quite get that you meant the buff trigger in your first comment. I cannot fix this unfortunately, the trick i am using with the debuff trigger is that the client does not know the duration of other players auras, but this is not the case for buffs. So you would have to track every aura applied manually to track whether buffs are your own. I started to implement something like that a while ago, but not sure when/if i have time to finish it. This is by the way also the reason why the own only option was hidden up to this point, mainly because there is no easy and clean way to implement it properly on 2.4.3.

[Nuy]

Ok i did not quite get that you meant the buff trigger in your first comment. I cannot fix this unfortunately, the trick i am using with the debuff trigger is that the client does not know the duration of other players auras, but this is not the case for buffs. So you would have to track every aura applied manually to track whether buffs are your own. I started to implement something like that a while ago, but not sure when/if i have time to finish it. This is by the way also the reason why the own only option was hidden up to this point, mainly because there is no easy and clean way to implement it properly on 2.4.3.

The thing is it doesn't work for debuffs either.

[RichSteini]

The thing is it doesn't work for debuffs either.

What setup do you mean? I am pretty sure that the debuff on "target" trigger works (this is also the most important one to track your debuffs). I don't really get why you guys want to track buffs on "player" own only, how does it matter from whom the buff comes from? For example shadow trance, this buff can only be from yourself therefore the own only option does absolutely nothing. With the unit selection "player" you already track only the player, you don't need to select own only.

[Nuy]

The thing is it doesn't work for debuffs either.

What setup do you mean? I am pretty sure that the debuff on "target" trigger works (this is also the most important one to track your debuffs). I don't really get why you guys want to track buffs on "player" own only, how does it matter from whom the buff comes from? For example shadow trance, this buff can only be from yourself therefore the own only option does absolutely nothing. With the unit selection "player" you already track only the player, you don't need to select own only.

True for buffs but can't make multi-DoTting WA either cause it doesn't work for debuffs too. Here's an example WA for Corruption tracking on multiple targets.

!WA:2!fA1xVnXXw8yTIs6YFkj5s6nPC5MIeu4wbLgkOQReQ41XgBKJTz9gmufj7z3DS3PSE2LzNnjoT3Bblenp7Vb1VuPQ(qL)eGYd95JI6hGQ8q)aKpb9m7UKaOw1xwpZzoN58VF)oJZ9GzJm)SRD9RD9z7pR7SU7CTreHtvkVN075ZVVDGWLkmiop2veegEgdF22BteUlzfe4lzHITQ3TBevw(Lp97)LFBQPMsmitWD68Dl8uuWec3Xlq0iGXL2fkwZQO54UX((fychFAhZOqId9ycIJKfWJULzKKiK62DzCwKNUb(JuFOuW61JkIw8sISLVySl1oUBxRbHur5IvBuATQgsCJjjwqwEyui13VIBK((rX20nOCztuB2wtAxiFtR2nTYBAzeJxUDOpzavyYj9Pr6MjQAxMs8LEhAAdbfn1SzJIvRokMNfc6tCc8J7ZBQYanBbXLfh98tomoIwL1Nj9mj(SECyAbMtkdYngVqtApvIQB4hqClzlj(OdM3SFmwo1nWW2zE4Y6Mo(KOi1kJi22u1I9SZ6cfc8de3tttRH21V2nhkc2mnceeoRprs9mJCWBvZoT55no93IU9OHZ08jXebDPsyhyPwEmjDSijGu1XDDhGvbMtprqCyMvnrVFmJOaHel4rouUlJ3B5yM7KRS6nBy26E2vxoEue1VBshEzR6nWissuDZChGsOcoX)byVdfW23btDjHllH97aHTz(vQSwZ9iXseIupmbcOVBQNtXrVRnAsxwp9XYaNnsVMPR)ZxG5EqlIWpW5XlTscqiAsxb2cBkfejrBupbZTfZv6DIdsbGLuNQYs7MfmlwS2qLgQ9xWCLjPESchDOMbM(BASs9w1m9vTXtKDAAzpxUCAJXqYLLgSty8UbI(j5R(O0oaU8wWjlTlLePINeU0XH5m4bC6EUi8uPrBfyverv3v0qLQQGbAA0NW4Lat0aOjybRbpa)9uVTKzDwCNpzmsEepojnp7ygEtndIfo0Znf8oLF5s)4pChK)bhhMEVe9mFvBjCM3y)QbUuJ8Rzv3qDfDG370xcoZVpoYlyZc(yih1bD8)yKIxLqswCCHaHioPBHn0(2moTbvSgsM6GLoEDU)GoWhaNd(NWLdplshwLiD8YuPTtaYG8GZQlWtQHxyhyrD4FbNhMhEFygr58MRIKz4FRhoJAQWguRu(Mko)PPsYt8sY4aAWTzW)fMEOnjRdPP6qiwLivvAQ3UjjBkA6r5GlEV5H52djIk6KcPZDZeG9rAQGDMp8dL0TKTt(K2FBh2wY6tBhkOomfkuB0HQCHlIJgt2f5rCXY2HqL9tL(k6bSE4CjsqeFGcP4K08mYJBpi1zSTOPa3NTxkW9rPHEUDto)RIJKSUdGPH5eymRKno5GJQiJYIAUm8mLeSTx6(XexfRyjlR9o8mfAZOg2EdN91I8mNDUPYC(dZCEQDBIeHwcs4WwzlsJPnW6HnolpRg8Ad8hxPwTIMTRwSKv45)RQOP7YfUWFIcPlmv65EuSRgkTq4v(RUWSXyTLEckII9Dh8g5ywoPTZC)jUKNTazA8lCroeK0gHqyD4jGaIEgiZbXQYpSbSzkcClya8niP7)dFl80oWZMKM1MvUBzlyB4RHxSa8)Yb7Oz7rz98W3g)ImU5LkbFKA2oCLKV)NKVFS67(jOwd8XbxfUF58RSs4zqctExfcG6sDxLSL3KeTkZCDPCZAfFqrt4(QrpV94Jw)9duGtGgQdNshoT(B7jg3dUHqnaazzWXY96uQhMBucJmI5snttzd9ufSW6ASGgE5kQNb6IVrTEbccF59miI1xRYvpA3vBQmilDsks3witnF4R(phWNpzWL7)PpQrbRBeSTX2bb9ZzMyHhui9nbOJ5MkUZZpj(2BOhrdUlugkQLoO8Who1emU6TeQhCh9jbcg(eCYOWXLRBw5lRxZkFvOUo0q)GJMsCiPo5z3z34xF4F8d

Stops appearing when "Own Only" is enabled and besides that I just noticed progress bar doesn't work at all and timer isn't showing. Looks like timer is broken too. There's an AddOn that does multi-DoT tracking of your own DoTs ONLY but the problem with it is that it won't distinguish 2 targets with the same name - https://github.com/Monteo/Chronometer.

[RichSteini]

Stops appearing when "Own Only" is enabled and besides that I just noticed progress bar doesn't work at all and timer isn't showing. Looks like timer is broken too. There's an AddOn that does multi-DoT tracking of your own DoTs ONLY but the problem with it is that it won't distinguish 2 targets with the same name - https://github.com/Monteo/Chronometer.

You can't distinguish units with the same name on 2.4.3 so i have doubts that multitarget tracking will ever work properly. Maybe some smart implementation can fix it, but i am not planning to do that, it's just too much work. It's a backport after all so it is what it is, there are some limitations in 2.4.3.

[Nuy]

"Own Only" should work tho right but it stops any WA from working.

[RichSteini]

"Own Only" should work tho right but it stops any WA from working.

I think we talked already about everything... Okay again: The option works with debuff trigger on "target" that was also the main intention that people wanted. I haven't tested anything else and i can for sure say that it does not work with your own buffs on "player", because the trick is that it checks whether the duration is nil. It doesn't break your weakauras when you do not activate it right? My recommondation: Use it for debuff trigger on "target" and do not use it for anything else, i could play around with it and make it do nothing on triggers where it doesn't work, but it is kind of irrelevant imo.

[Nuy]

I don't mean buffs here. It doesn't work for ANYTHING (debuffs too) even if Trigger is target and when you debuff something it clearly states ":your nick:'s :spell name: hits the..." even in 2.4.3 Combat Log so it shouldn't be a problem for an AddOn to know which are your debuffs. Chronometer shows only your debuffs without issues so WA should be able to do that too.

[RichSteini]

I don't mean buffs here. It doesn't work for ANYTHING (debuffs too) even if Trigger is target and when you debuff something it clearly states ":your nick:'s :spell name: hits the..." even in 2.4.3 Combat Log so it shouldn't be a problem for an AddOn to know which are your debuffs. Chronometer shows only your debuffs without issues so WA should be able to do that too.

Show me a video footage where it does not work for debuff on "target" and link me the weakaura. It is not implemented by scanning the combatlog, it is a port from WOTLK where the UnitAura function was used which does not exist in 2.4.3. In 2.4.3 you only have UnitBuff and UnitDebuff functions which do not give you information whether it is your own. In this backport the UnitAura function is imitated by using UnitBuff and UnitDebuff functions which lack information. I am not saying that you can't implement it in a different way by tracking the combatlog for example, the problem is that it is not easy and i do not have time for it. Just saying everyone can contribute to this repository, the source code is public, so if you find someone that has time and wants to fix it, feel free.

[RichSteini]

I don't mean buffs here. It doesn't work for ANYTHING (debuffs too) even if Trigger is target and when you debuff something it clearly states ":your nick:'s :spell name: hits the..." even in 2.4.3 Combat Log so it shouldn't be a problem for an AddOn to know which are your debuffs. Chronometer shows only your debuffs without issues so WA should be able to do that too.

Another thing, maybe it does not work because you have bufflib or something similar installed. Make also sure to disable all other addons while testing when report or provide footage.

[Nuy]

I was wrong, only doesn't work for target Trigger in a specific but normally all is fine.