Richard-Burns / SimpleMixer

A video mixer built in TouchDesigner
The Unlicense
198 stars 21 forks source link

Drag/Drop TOXES and Post/FX issue #23

Closed SaharUsha closed 6 years ago

SaharUsha commented 6 years ago

Drag/drop of the toxes into the banks and the POST/FX into their place, doesn't seem to work like it did in the previous version.

Richard-Burns commented 6 years ago

Are you getting any errors in the network from that? They seem to be dragging fine on my side. I'm running build 25000. In fact the Post FX box's havent been updated with the GUI so it's odd if they dont work. If there's an error it should be at /simplemixer/container_gui/container_show/container_userpanel/container_postfx/container_banks/container_bank1

Richard-Burns commented 6 years ago

Ahh I'm going to assume this is the DPI scaling issue. Setting DPI scaling to 100% will now fix this issue.

SaharUsha commented 6 years ago

hi Richard.

here is a video recording for you: https://www.dropbox.com/s/p7q3pqlfb1teu01/2018-08-24%2015-35-09.mp4?dl=0

I dont seem to have any scaling issues. The UI and the output show fine on my 2 monitors. but the drag/drop of the TOXs dont work.

On Thu, Aug 23, 2018 at 9:18 PM Richard-Burns notifications@github.com wrote:

Ahh I'm going to assume this is the DPI scaling issue. Setting DPI scaling to 100% will now fix this issue.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Richard-Burns/SimpleMixer/issues/23#issuecomment-415538197, or mute the thread https://github.com/notifications/unsubscribe-auth/AdzCIyt0W0zTCTb3XtU220qJk7oQbxU0ks5uTwAegaJpZM4WJ4Kk .

-- Sahar Homami MOTION | VFX | LIVE VISUALS W www.SaharHomami.com http://www.saharhomami.com/

SaharUsha commented 6 years ago

Forgot to mention, I get no errors in the network.

On Fri, Aug 24, 2018 at 3:37 PM Sahar Homami s.h1364@gmail.com wrote:

hi Richard.

here is a video recording for you: https://www.dropbox.com/s/p7q3pqlfb1teu01/2018-08-24%2015-35-09.mp4?dl=0

I dont seem to have any scaling issues. The UI and the output show fine on my 2 monitors. but the drag/drop of the TOXs dont work.

On Thu, Aug 23, 2018 at 9:18 PM Richard-Burns notifications@github.com wrote:

Ahh I'm going to assume this is the DPI scaling issue. Setting DPI scaling to 100% will now fix this issue.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Richard-Burns/SimpleMixer/issues/23#issuecomment-415538197, or mute the thread https://github.com/notifications/unsubscribe-auth/AdzCIyt0W0zTCTb3XtU220qJk7oQbxU0ks5uTwAegaJpZM4WJ4Kk .

-- Sahar Homami MOTION | VFX | LIVE VISUALS W www.SaharHomami.com http://www.saharhomami.com/

-- Sahar Homami MOTION | VFX | LIVE VISUALS W www.SaharHomami.com http://www.saharhomami.com/

Richard-Burns commented 6 years ago

Ok thats super odd...even with DPI scaling wrong mine still shows the drag arrow so this must be something else. Firstly I'm on build 25000 so that should work.

The component at /simplemixer/container_gui/container_show/container_grid/container_toxs/container_tox1 should have it's drag/drop page parameter called "when dragging this" set to "Legacy Drag System".

The component at /simplemixer/container_gui/container_show/container_mixer/slide_viewer_topleft should have it's drag/drop page parameter called "On Dropping Into" set to "Legacy Drop System" and it's drop script should be set to "text_dropscript"

If those are set then it must be some kind of touchdesigner bug

Richard-Burns commented 6 years ago

Weirdly I've just spotted some kind of cooking bug where if you drag then drop it doesn't update until you drag the slider and only then does it cook the ops and import the visual. I'll investigate this further. This is usually a result of touchdesigner optimizing things too far.

Richard-Burns commented 6 years ago

Do the two blend mode menus still show up in the correct place or can you not see them when you click to change the blend mode?

SaharUsha commented 6 years ago

Hello Richard, I hope you are well.

My apologies for the late answer. There was Atonal in Berlin this weekend and then some other non Touchdesigner deadlines.

I am now back to this. I went through your notes and double-checked all drag-drop operators in their respective containers. All looks good.

"Weirdly I've just spotted some kind of cooking bug where if you drag then drop it doesn't update until you drag the slider and only then does it cook the ops and import the visual. I'll investigate this further. This is usually a result of touchdesigner optimizing things too far." >>> Regarding this, It doesn't work on my side, by dragging the slider. I have tried dragging the slider left and right, but the drop function still doesn't work. It seems like Drag works, but not the drop function.

-Also, I just noticed, where previously we could activate the component menu on the bottom, by right-clicking on the Toxes in the banks, also doesn't activate the menu of that Tox.

On Fri, Aug 24, 2018 at 6:55 PM Richard-Burns notifications@github.com wrote:

Do the two blend mode menus still show up in the correct place or can you not see them when you click to change the blend mode?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Richard-Burns/SimpleMixer/issues/23#issuecomment-415818352, or mute the thread https://github.com/notifications/unsubscribe-auth/AdzCIyywzwIqfg0Sb9XPXLXeh7-8KRbnks5uUC_1gaJpZM4WJ4Kk .

-- Sahar Homami MOTION | VFX | LIVE VISUALS W www.SaharHomami.com http://www.saharhomami.com/

Richard-Burns commented 6 years ago

This seems to be a hardware specific problem or bug with TouchDesigner as I can't reproduce it on 3 different PCs. (Are you on mac?)

I'll build in a drag-drop alternative and I think that should solve that issue. I'll close this issue when the feature is in with comments on that. I'm thinking you right click on a tox/movie and then a little menu comes up saying "assign to top left, top right, bottom left, bottom right". For Post Effects this would just be click on the bank and then right click -> assign on the post effect you want to add.

I might be able to put that fix in tonight.

SaharUsha commented 6 years ago

Hey Richard

Thanks, I will look for it.

and I'm on a PC.

maybe the next TD update will help fix this.

Thank you for troubleshooting this.

Cheers

On Wed, Aug 29, 2018 at 10:22 AM Richard-Burns notifications@github.com wrote:

This seems to be a hardware specific problem or bug with TouchDesigner as I can't reproduce it on 3 different PCs. (Are you on mac?)

I'll build in a drag-drop alternative and I think that should solve that issue. I'll close this issue when the feature is in with comments on that. I'm thinking you right click on a tox/movie and then a little menu comes up saying "assign to top left, top right, bottom left, bottom right". For Post Effects this would just be click on the bank and then right click -> assign on the post effect you want to add.

I might be able to put that fix in tonight.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Richard-Burns/SimpleMixer/issues/23#issuecomment-416868193, or mute the thread https://github.com/notifications/unsubscribe-auth/AdzCIxGVeOjvQxFwEWGxDKwTvLoIhepfks5uVk9KgaJpZM4WJ4Kk .

-- Sahar Homami MOTION | VFX | LIVE VISUALS W www.SaharHomami.com http://www.saharhomami.com/

Richard-Burns commented 6 years ago

There is now a workaround for broken drag/drop in TouchDesigner in 0.9.3. Drag Drop can now be avoided by selecting the TOX/Movie you wish to assign and right clicking the bank you want to assign it to. For PostFX you can simply select a bank and then left click the Post Effect you want to apply to it.

SaharUsha commented 6 years ago

Updating to newer TD versions fixed the drag/drop issues. One issue still remains and that is right click on the banks on the top, doesn't activate/highlight the corresponding TOX parameter menus.

Richard-Burns commented 6 years ago

The right click was intended as a fix to the drag/drop issue so I think I removed it? Drag/Drop should work again now as a replacement, let me know if it's still broken and I'll put another fix in.

SaharUsha commented 6 years ago

I meant the original function of the right click as in the previous version of SimpleMixer.

On Tue, Oct 30, 2018 at 11:17 AM Richard-Burns notifications@github.com wrote:

The right click was intended as a fix to the drag/drop issue so I think I removed it? Drag/Drop should work again now as a replacement, let me know if it's still broken and I'll put another fix in.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Richard-Burns/SimpleMixer/issues/23#issuecomment-434244635, or mute the thread https://github.com/notifications/unsubscribe-auth/AdzCI-e5L5ZrxHsardg-ayhZkw-0wE9vks5uqCdDgaJpZM4WJ4Kk .

-- Sahar Homami MOTION | VFX | LIVE VISUALS W www.SaharHomami.com http://www.saharhomami.com/

Richard-Burns commented 6 years ago

Ahh...man I can't even remember what I changed! Ok cool I'll have a look into that and push a fix, issue re-opened until I'm off-site and can fix it.

Richard-Burns commented 6 years ago

Hi Sahar,

Yeah it seems I replaced the right click with the clip selector, this has been reverted back to the original setting of setting the bottom right panel to the right clicked bank.

This is fixed in 1.0.0 which I'm about to upload.

Cheers, Rich