Richard-Gemmell / teensy4_i2c

An I2C library for the Teensy 4. Provides slave and master mode.
MIT License
92 stars 19 forks source link

Avoid use of Serial in driver_wire #38

Open hmaarrfk opened 9 months ago

hmaarrfk commented 9 months ago

Hey thank you for creating this library.

I know these are huge hassles and it has helped me tremendously in the teensy4 migration from the teensy 3.2.

I was wondering if you would considering removing the print statement in https://github.com/Richard-Gemmell/teensy4_i2c/blob/7cc79e3d09697770c5c2d12ae0e6b8dc6e1d5ee3/src/i2c_driver_wire.cpp#L127

it is somewhat annoying to have "print" statements that speak of serial as it breaks your other communication protocols if they speak over Serial.

Maybe we could consider returning True/False instead of printing?