search

Richard-Weiss / Bing-Creator-Image-Downloader

Downloads all Bing Creator images from a collection
MIT License
38 stars 8 forks source link

Fallbacks for fetching images #17

Closed Richard-Weiss closed 8 months ago

Richard-Weiss commented 10 months ago

It would be better to use retryclient.requests and a list of requests to have different fallbacks when fetching an image.
The order should be:

  1. collections API MediaUrl
  2. async details API contentUrl
  3. collections API item['content']['thumbnails'][0]['thumbnailUrl']
  4. async details API thumbnailUrl However to prevent unnecessary requests, the main image and thumbnail url should be compared first, as they are often the same.
Richard-Weiss commented 9 months ago

It would also be nice to see some kind of statistic to see how many images failed to download, as the current implementation doesn't account for it and the output may be misleading. Moved to #26.