Richard87 / releaser

Simple notification when repositories is updated
https://releaser.richardhagen.no
MIT License
69 stars 3 forks source link

Logged is as null #18

Closed mikhail-softgrad closed 7 years ago

mikhail-softgrad commented 7 years ago

Hello I always got follow message in the bottom page

image

Maybe is it bug?

msteer commented 7 years ago

I think this might be because you do not have a name set in your GitHub profile.

Richard87 commented 7 years ago

Yup, that's exactly the problem.

AlexWayfer commented 7 years ago

Yup, that's exactly the problem.

Maybe Releaser should display nickname, if profile name is null? Why did you close the issue?

Richard87 commented 7 years ago

Yeah, we could update it to show the email if displayName is null

AlexWayfer commented 7 years ago

Yeah, we could update it to show the email if displayName is null

Um, why? For example, you have:

We could show nickname (it's required for user) if profile name (not required) is empty, not email (not required).

Richard87 commented 7 years ago

Hi, we don't have Nickname, we always have email, but sometimes displayName...

Richard

tor. 29. jun. 2017 kl. 16:41 skrev Alexander Popov <notifications@github.com

:

Yeah, we could update it to show the email if displayName is null

Um, why? For example, you have:

  • Profile name: Richard Hagen
  • Nickname: Richard87
  • Email: undefined

We could show nickname (it's required for user) if profile name (not required) is empty, not email (not required).

β€” You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/Richard87/releaser/issues/18#issuecomment-311987873, or mute the thread https://github.com/notifications/unsubscribe-auth/AFe70y3fjLMmKLjt5uL0DwP7NcEejk8_ks5sI7eCgaJpZM4OG4Wb .

AlexWayfer commented 7 years ago

@Richard87 So, and what is your email?

image

Richard87 commented 7 years ago

To specify, from Firebase Authentication, we just get displayName (in this example, "Richard Hagen") and email :)

tor. 29. jun. 2017 kl. 16:59 skrev Alexander Popov <notifications@github.com

:

@Richard87 https://github.com/richard87 So, and what is your email?

[image: image] https://user-images.githubusercontent.com/6510020/27694417-afe5768c-5cf4-11e7-8d53-75ec15cb441f.png

β€” You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/Richard87/releaser/issues/18#issuecomment-311993764, or mute the thread https://github.com/notifications/unsubscribe-auth/AFe704oBOF5lNqaBNgKkQZyivvzUnfezks5sI7vegaJpZM4OG4Wb .

AlexWayfer commented 7 years ago

@Richard87 Oh, okay, thank you.

Richard87 commented 7 years ago

No problem!

tor. 29. jun. 2017 kl. 18:31 skrev Alexander Popov <notifications@github.com

:

@Richard87 https://github.com/richard87 Oh, okay, thank you.

β€” You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/Richard87/releaser/issues/18#issuecomment-312021294, or mute the thread https://github.com/notifications/unsubscribe-auth/AFe708HaqrTxdjpnQe0L3E-kXZiO7Ovvks5sI9FzgaJpZM4OG4Wb .

Richard87 commented 7 years ago

@AlexWayfer Could you test that it works as expected now?

AlexWayfer commented 7 years ago

@AlexWayfer Could you test that it works as expected now?

Production? Still null :disappointed:

Richard87 commented 7 years ago

ahh, thanks, I forgot to push deploy :O

sΓΈn. 6. aug. 2017 kl. 20:52 skrev Alexander Popov <notifications@github.com

:

@AlexWayfer https://github.com/alexwayfer Could you test that it works as expected now?

Production https://releaser.richardhagen.no/? Still null 😞

β€” You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/Richard87/releaser/issues/18#issuecomment-320508327, or mute the thread https://github.com/notifications/unsubscribe-auth/AFe7045xLK1z_1-RGAwh2LFSiOSX4S30ks5sVcU2gaJpZM4OG4Wb .

Richard87 commented 7 years ago

@AlexWayfer Just pushed new version, could you try again? Sorry for the inconvenience! I appreciate your help :)

AlexWayfer commented 7 years ago

Sure, no problem!

I checked: now the email is displayed :tada:

You can close this issue :)

Richard87 commented 7 years ago

Thanks man!