search

Richard87 / releaser

Simple notification when repositories is updated
https://releaser.richardhagen.no
MIT License
69 stars 3 forks source link

Optionally wait for releases to contain a name / body / attachements #9

Open sschuberth opened 7 years ago

sschuberth commented 7 years ago

I recently got notified about PMD 5.5.6:

2017-04-20_085034

As you can see from the screenshot, while a release was created from a tag, the release does not have a name, body or attachments yet. How about adding an option to only trigger the notification once a release has some name / body / attachments?

More generally, some additional options would be nice, like whether to consider prereleases or not.

Richard87 commented 7 years ago

Hi, it's a good idea, but I don't have time to implement it, you are welcome to submit a PR :)

Richard

tor. 20. apr. 2017 kl. 08:59 skrev Sebastian Schuberth < notifications@github.com>:

I recently got notified about PMD 5.5.6:

[image: 2017-04-20_085034] https://cloud.githubusercontent.com/assets/349154/25217300/9effdce8-25a6-11e7-813c-96e997daec55.png

As you can see from the screenshot, while a release was created from a tag, the release does not have a name, body or attachments yet. How about adding an option to only trigger the notification once a release has some name / body / attachments?

More generally, some additional options would be nice, like whether to consider prereleases or not.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Richard87/releaser/issues/9, or mute the thread https://github.com/notifications/unsubscribe-auth/AFe708f-2uYa25AB5N8xYX7HzxVtndORks5rxwJqgaJpZM4NCnkr .

sschuberth commented 7 years ago

Maybe some time, if I feel like doing JavaScript / TypeScript (which is hardly ever the case) :-D

Richard87 commented 7 years ago

Hehe, feel free ;) I'll leave this as closed at the moment tho :)

sschuberth commented 7 years ago

Why closing it when you agree it's a good idea? IMO it should stay open for contributors to pick, just label it accordingly.

AlexWayfer commented 7 years ago

Why closing it when you agree it's a good idea? IMO it should stay open for contributors to pick, just label it accordingly.

I agree.

@Richard87 Just add the label help wanted, for example, and leave it open, please.

Richard87 commented 7 years ago

Thanks guys, you are right :) I'm new to this Open Source stuff ;)