search

RichardEssery / FSM2

Flexible Snow Model - a multi-physics energy balance model of accumulation and melt of snow on the ground and in forest canopies
MIT License
26 stars 13 forks source link

Treatement of rainfall #8

Closed GiuliaMazzotti closed 6 years ago

GiuliaMazzotti commented 6 years ago

Liquid precipitation should be added to surface melt, not directly to runoff

RichardEssery commented 6 years ago

Rain is added at the snow surface and not directly to runoff, but that might not be clear in the code. Variable Roff is used as interim storage for water fluxes at snow layer boundaries, so it is set to rainfall at the surface and is only equal to runoff at the base of the snow once the model has looped down through the snow layers. Can we close this issue, or do you think that a new water flux variable should be introduced for clarity?

GiuliaMazzotti commented 6 years ago

Ok, that's fine. This issue came up talking to the OSHD people as well. I don't think a further variable is needed, I will have a closer look and get back to you in case of any open questions...

-----Richard Essery notifications@github.com schrieb: ----- An: RichardEssery/FSM2 FSM2@noreply.github.com Von: Richard Essery notifications@github.com Datum: 13.02.2018 10:09 Kopie: GiuliaMazzotti giulia.mazzotti@slf.ch, Author author@noreply.github.com Betreff: Re: [RichardEssery/FSM2] Treatement of rainfall (#8)

Rain is added at the snow surface and not directly to runoff, but that might not be clear in the code. Variable Roff is used as interim storage for water fluxes at snow layer boundaries, so it is set to rainfall at the surface and is only equal to runoff at the base of the snow once the model has looped down through the snow layers. Can we close this issue, or do you think that a new water flux variable should be introduced for clarity? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

RichardEssery commented 6 years ago

No action required