search

RichardHooijmaijers / shinyMixR

run management tool for nlmixr
https://richardhooijmaijers.github.io/shinyMixR/index.html
Other
11 stars 4 forks source link

Update tests #22

Closed RichardHooijmaijers closed 6 months ago

RichardHooijmaijers commented 7 months ago

This PR is to update tests in the package:

  1. Split functionality between shinytest2 and testthat
  2. Split some tests up in smaller chunk to test single functionality
codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.25%. Comparing base (c991b50) to head (be501e5).

:exclamation: Current head be501e5 differs from pull request most recent head e2629f9. Consider uploading reports for the commit e2629f9 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #22 +/- ## ========================================== + Coverage 53.16% 53.25% +0.08% ========================================== Files 27 27 Lines 1153 1153 ========================================== + Hits 613 614 +1 + Misses 540 539 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RichardHooijmaijers commented 7 months ago

Discuss this PR. Changed part of the structure for testing to separate shinytest (do we get any results) vs functional testing (does the result make sense). Also added argument incres argument in setup_shinymixr_test function. This way we do not have to run a model to perform tests where results are compared. Found errors in test coverage and r cmd check that needs further investigation..