search

RichardKnop / machinery

Machinery is an asynchronous task queue/job queue based on distributed message passing.
Mozilla Public License 2.0
7.52k stars 914 forks source link

switching task.Headers to use http.Header #774

Closed Jarch09 closed 10 months ago

Jarch09 commented 2 years ago

To make opentracing compatible with opentelemetry, we should be using http Headers.

Here's the relevant code in the opentracing shim for opentelemetry: https://github.com/open-telemetry/opentelemetry-go/blob/main/bridge/opentracing/bridge.go#L646

Making this change keeps machinery compatible with opentracing and enables integration with opentelemetry.

Jarch09 commented 2 years ago

@RichardKnop - this is a quick fix, and I'd really like to get this merged, so I can start using opentelemetry with machinery

Jarch09 commented 2 years ago

@ggodik - would really appreciate if we can get this merged

munir131 commented 2 years ago

@Jarch09 Looks like no one have time to review PRs. My one liner 3 months old PR still not merged.

Jarch09 commented 2 years ago

@Jarch09 Looks like no one have time to review PRs. My one liner 3 months old PR still not merged.

Then we need new / more maintainers... I'd be willing to review PRs occasionally.

Jarch09 commented 2 years ago

^ @RichardKnop @ggodik, can we open things up to more maintainers?

ggodik commented 2 years ago

@Jarch09 agree. submissions here have really slowed down. However I dont have elevated privs on this repo :(

Jarch09 commented 2 years ago

@Jarch09 agree. submissions here have really slowed down. However I dont have elevated privs on this repo :(

Is it only @RichardKnop ?