search

RichardKnop / machinery

Machinery is an asynchronous task queue/job queue based on distributed message passing.
Mozilla Public License 2.0
7.52k stars 914 forks source link

AMQP: nack the message with requeue false when IgnoreWhenTaskNotRegistered #798

Open surendratiwari3 opened 8 months ago

surendratiwari3 commented 8 months ago

Description

This pull request addresses an issue related to the handling of AMQP based task messages when a task is not registered with the worker, and IgnoreWhenTaskNotRegistered is set. The existing logic is adjusted to correctly NACK the message with requeue=false in these scenarios.

Changes Made

Impact

This fix ensures consistent and correct behavior in handling AMQP messages, especially in scenarios where tasks are not registered, and IgnoreWhenTaskNotRegistered is configured.

surendratiwari3 commented 8 months ago

@RichardKnop Please review

surendratiwari3 commented 8 months ago

@RichardKnop please check this also it's required bug fix.

surendratiwari3 commented 8 months ago

@RichardKnop Please check this.