search

RichardLitt / standard-readme-preset

remark preset to configure remark-lint with settings that enforce standard-readme.
ISC License
12 stars 8 forks source link

Node.js 15 compatibility #38

Closed piranna closed 3 years ago

piranna commented 3 years ago

https://github.com/RichardLitt/standard-readme-preset/blob/9a525557875c0f47fbacfbe54917adabde02cf11/package.json#L31

Change engines field to add support for Node.js 15.

RichardLitt commented 3 years ago

PRs accepted. Thanks for pointing this out.

piranna commented 3 years ago

At https://github.com/RichardLitt/standard-readme-preset/blob/eb594da2645d21482b173bd4119519287d7a3e53/package.json#L31 it shows already support Node.js 15, so this could be closed, but maybe it's not the best solution and we would need to use ranges instead... what do you think?

RichardLitt commented 3 years ago

Ranges should work. Not sure why we're skipping 11. I'm also unsure of how useful this field is, anyway; I know I haven't used it, personally.

wooorm commented 3 years ago

I'd strongly suggest something like '>=10' or so. It makes sure that every future release is allowed. If something doesn't work, folks will raise issues anyway 🤷‍♂️

RichardLitt commented 3 years ago

Sounds good to me! @piranna want to PR?

piranna commented 3 years ago

Sounds good to me! @piranna want to PR?

https://github.com/RichardLitt/standard-readme-preset/pull/42

Here you have it :-)