RichardObi / medigan

medigan - A Python Library of Pretrained Generative Models for Medical Image Synthesis
https://medigan.readthedocs.io/en/latest/
MIT License
115 stars 13 forks source link

add conda recipe and badge #58

Closed sarthakpati closed 1 year ago

sarthakpati commented 1 year ago

Great work on this!

Adding this PR because having a conda recipe is great to daisy-chain complex dependencies (especially those that require C++). I am happy to shepherd the recipe, or if you would want to be added as a maintainer. 😄

sarthakpati commented 1 year ago

FYI, the badge is not coming up yet because the recipe has started rendering: https://github.com/conda-forge/medigan-feedstock/runs/12341090226

EDIT: it is now up:

image
faildeny commented 1 year ago

Thanks for contributing! Adding a conda recipe is a good idea. I just tested and it works correctly.

sarthakpati commented 1 year ago

Good idea and thank you very much for taking the initiative @sarthakpati 🥇

I also tested the conda recipe and it worked perfectly.

The CI issue is not related to this PR and will be fixed separately in #59 , therefore this PR is ready for merge.

@sarthakpati It would be nice if you could add @faildeny and myself @RichardObi as maintainers to medigan-feedstock.

Thanks!

And maintainers have been added: https://github.com/conda-forge/medigan-feedstock/pull/3