search

RichardRNStudio / react-native-slider-intro

A simple and full customizable React Native package which implements a unique slider.
MIT License
153 stars 3 forks source link

Icon Instead of IMAGE #3

Closed teamseamive closed 3 years ago

teamseamive commented 3 years ago

Hello,

Can we use Icon or LottieView instead of an Image?

RichardRNStudio commented 3 years ago

Hey @seamive, You can use the renderItem function to render a custom slide. I'll put a new example into the examples folder soon about how you can do this.

teamseamive commented 3 years ago

Sure, please do the needful, have been looking for it a long time. Also looking if we can make it more materialistic using react-native-paper or something similar.

RichardRNStudio commented 3 years ago

Hey @seamive,

I haven't tried the react-native-paper, but I think you can make it with the renderItem function.

The following example will show you how you can customize the layout with renderItem function. https://github.com/RichardRNStudio/react-native-slider-intro/blob/main/example/src/CustomRenderFunctionExample.js

The package has been updated, so you can test the new example on your local machine.

Can I close the issue?

teamseamive commented 3 years ago

Still don't know how to implement Icon or LottieView with this, can you create an example with it? That would be really helpful.

RichardRNStudio commented 3 years ago

You can create anything inside the renderItem function, did you see the example?

teamseamive commented 3 years ago

Yes, we did see, unable to understand how to properly apply for Icons and LottieView, can you add a feature request to support ICON and LottieView to those?

RichardRNStudio commented 3 years ago

Instead of the image on center, right? I'll do it soon.

teamseamive commented 3 years ago

Here are some great feature requests:

  1. Support to use Icons like FontAwesome, RN Vector Icons, LottieView instead of "image"
  2. Adding customized text and widget like Shimmer Place Holder
  3. Adding dynamic text in sliders.

We would love to contribute to the project if we can.

Thanks!

teamseamive commented 3 years ago

@RichardRNStudio: We hope you're doing great, any updates on this?

RichardRNStudio commented 3 years ago

@seamive I'm fine, thank you. I hope you're well too. Unfortunately I didn't have enough free time to do this, but I'll make the necessary changes on this weekend! I'll let you know when the code is ready.

teamseamive commented 3 years ago

@RichardRNStudio: any updates?

RichardRNStudio commented 3 years ago

@seamive Sorry, I didn't have time to do it, but I'll today afternoon.

teamseamive commented 3 years ago

Sure, thanks!

RichardRNStudio commented 3 years ago

@seamive I've created one more example how you can customize the renderItem function with third party libraries. The example includes:

So as you can see you can do anything inside this function.

The example: https://github.com/RichardRNStudio/react-native-slider-intro/blob/main/example/src/UsingThirdPartyLibrariesExample.js

I close the issue, if you have more questions then open a different one, please.

Best regards, RNStudio

teamseamive commented 3 years ago

Thank you so much! Though we were really Looking forward to the support of LottieViews, we'll give it a spin ourselves to that! <3

teamseamive commented 3 years ago

Just wanted to confirm if this is right or wrong? https://github.com/RichardRNStudio/react-native-slider-intro/blob/main/example/src/UsingThirdPartyLibrariesExample.js#L157

Also, the styles you have applied in the same file are default ones?

RichardRNStudio commented 3 years ago

No, they're not the default ones, and yes it's correct on this example, but you can change/customize all of styles on your way. It's fully customizable.